tillrohrmann commented on a change in pull request #9663: 
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r323241522
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingLogicalSlot.java
 ##########
 @@ -71,7 +71,7 @@
                this.slotNumber = slotNumber;
                this.allocationId = Preconditions.checkNotNull(allocationId);
                this.slotRequestId = Preconditions.checkNotNull(slotRequestId);
-               this.slotSharingGroupId = 
Preconditions.checkNotNull(slotSharingGroupId);
+               this.slotSharingGroupId = slotSharingGroupId;
 
 Review comment:
   `@Nullable` annotation is missing from the field

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to