Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1227#issuecomment-145876037
- It is very tightly coupled in in case of recovery. We won't loose this,
but I agree to introduce an interface to hide this (with a no-op implementation
for standalone mode and the filesystem implementation in case of recovery). I
fully agree that it's not a good way to do it, but this is blocking #1153. Is
that OK?
- There is no check for the provided path. It's the same behaviour as the
configured checkpoint directory `STATE_BACKEND_FS_DIR`. I think the check would
have to be performed on the task managers. A check for "file://" does not
suffice, because this can also be a DFS. I would open a issue for this and then
fix it for the `STATE_BACKEND_FS_DIR` as well.
- I'm still undecided about the shutdown hook. It was removed to exactly
prevent SIGTERM from removing all recovery data, but the actor postStop will be
called after SIGTERM as well and then it will remove it anyways. I think the
only advantage (which doesn't justify it) is for tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
