[
https://issues.apache.org/jira/browse/FLINK-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916425#comment-16916425
]
Kostas Kloudas commented on FLINK-13850:
----------------------------------------
No, actually I like the idea of having a programatic way of configuring format
specific stuff. And actually this is needed especially for bulk formats where
they have their own configurations that they expose to users (e.g. compression
schemes for Parquet). Maybe simply {{OutputConfig}} , and if users want to have
a config for a specific format (e.g. Parquet) they can have a
{{ParquetOutpuConfig}} that extends the {{OutputConfig}}. What do you think?
> Refactor part file configuration into a single method
> -----------------------------------------------------
>
> Key: FLINK-13850
> URL: https://issues.apache.org/jira/browse/FLINK-13850
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / FileSystem
> Reporter: Gyula Fora
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently there is only two methods on both format builders
> withPartFilePrefix and withPartFileSuffix for configuring the part files but
> in the future it is likely to grow.
> * More settings, different directories for pending / inprogress files etc
> I suggest we remove these two methods and replace them with a single :
> withPartFileConfig(..) where we use an extensible config class.
> This should be fixed before 1.10 in order to not release the other methods.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
