[
https://issues.apache.org/jira/browse/FLINK-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916025#comment-16916025
]
Kostas Kloudas commented on FLINK-13850:
----------------------------------------
Before we have such a change, let's think of what we want to add. The reason is
two-fold:
1) making a change just for being "future-proof" without a clear goal can lead
to just a "cosmetics" change with no effect
2) the "withPartFileConfig" may not be a solution if we want to add more
configuration parameters in the config, as this will lead to either having to
build the whole configuration, although the user may only need to change 1
parameter, or to a constructor for the config that follows the "telescoping
(anti-)pattern".
Could you describe what do you have in mind as potential changes [~gyfora] ?
> Refactor part file configuration into a single method
> -----------------------------------------------------
>
> Key: FLINK-13850
> URL: https://issues.apache.org/jira/browse/FLINK-13850
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / FileSystem
> Reporter: Gyula Fora
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently there is only two methods on both format builders
> withPartFilePrefix and withPartFileSuffix for configuring the part files but
> in the future it is likely to grow.
> * More settings, different directories for pending / inprogress files etc
> I suggest we remove these two methods and replace them with a single :
> withPartFileConfig(..) where we use an extensible config class.
> This should be fixed before 1.10 in order to not release the other methods.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
