carp84 commented on a change in pull request #9364:
[FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in
CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r311253548
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -859,7 +860,7 @@ private void completePendingCheckpoint(PendingCheckpoint
pendingCheckpoint) thro
catch (Exception e1) {
// abort the current pending checkpoint if we
fails to finalize the pending checkpoint.
if (!pendingCheckpoint.isDiscarded()) {
-
failPendingCheckpoint(pendingCheckpoint,
CheckpointFailureReason.FINALIZE_CHECKPOINT_FAILURE, e1);
+
failPendingCheckpoint(pendingCheckpoint,
CheckpointFailureReason.FINALIZE_CHECKPOINT_FAILURE, e1, null);
Review comment:
I already have introduced a new `handleCheckpointException` method with 3
parameters, and it requires to do a type casting on `null` when introducing
another one and invoking with `null` as the last parameter, which I _thought_
to be not recommended. But after a [search and
check](https://coderanch.com/t/382683/java/Casting-null-object) I believe it's
fine for casting null to help compiler choose between overloading methods, so
yes let me do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
