carp84 commented on a change in pull request #9364:
[FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in
CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r311156402
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1407,14 +1412,23 @@ private void failPendingCheckpoint(
failPendingCheckpoint(pendingCheckpoint, reason, null);
}
+ private void failPendingCheckpoint(
+ final PendingCheckpoint pendingCheckpoint,
+ final CheckpointFailureReason reason,
+ final ExecutionAttemptID executionAttemptID) {
+
+ failPendingCheckpoint(pendingCheckpoint, reason, null,
executionAttemptID);
+ }
+
private void failPendingCheckpoint(
final PendingCheckpoint pendingCheckpoint,
final CheckpointFailureReason reason,
- final Throwable cause) {
+ final Throwable cause,
+ final ExecutionAttemptID executionAttemptID) {
Review comment:
It's suggested to not using `Optional` as parameters, please refer to my
[reply](https://s.apache.org/nbl83) here. And yes will add `@Nullable`
annotation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
