tillrohrmann commented on a change in pull request #9242: 
[FLINK-13408][runtime] Schedule 
StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership 
is acquired
URL: https://github.com/apache/flink/pull/9242#discussion_r308266668
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 ##########
 @@ -1070,6 +1074,14 @@ protected void setFailUnfulfillableRequest(boolean 
failUnfulfillableRequest) {
                
slotManager.setFailUnfulfillableRequest(failUnfulfillableRequest);
        }
 
+       protected void startStartupPeriod() {
+               // noop
+       }
+
+       protected void resetStartupPeriod() {
 
 Review comment:
   I think we don't need this method. Instead we could let the 
`startStartupPeriod` always call `setFailUnfillableRequests(false)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to