tillrohrmann commented on a change in pull request #9242: [FLINK-13408][runtime] Schedule StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership is acquired URL: https://github.com/apache/flink/pull/9242#discussion_r307812176
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManager.java ########## @@ -112,4 +103,21 @@ protected ResourceID workerStarted(ResourceID resourceID) { return resourceID; } + @Override + protected void setFailUnfulfillableRequest(boolean failUnfulfillableRequest) { + if (failUnfulfillableRequest) { + final long startupPeriodMillis = startupPeriodTime.toMilliseconds(); + + if (startupPeriodMillis > 0) { + getRpcService().getScheduledExecutor().schedule( + () -> getMainThreadExecutor().execute( + () -> super.setFailUnfulfillableRequest(failUnfulfillableRequest)), + startupPeriodMillis, + TimeUnit.MILLISECONDS + ); + } + } else { + super.setFailUnfulfillableRequest(failUnfulfillableRequest); Review comment: Let's replace `failUnfillableRequest` with `false` here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services