tillrohrmann commented on a change in pull request #9126:
[FLINK-13242][tests][coordination] Get SlotManager.failUnfulfillableRequest in
main thread of StandaloneResourceManager for verification
URL: https://github.com/apache/flink/pull/9126#discussion_r306353710
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerTest.java
##########
@@ -105,10 +100,22 @@ private StandaloneResourceManager
createResourceManager(Time startupPeriod) thro
rm.start();
rmServices.grantLeadership();
- return new Tuple2<>(rm, rmServices.slotManager);
+ return rm;
+ }
+
+ private static boolean isFailingUnfulfillableRequest(
+ StandaloneResourceManager resourceManager) throws
InterruptedException {
+ try {
+ return
resourceManager.isFailingUnfulfillableRequestAsync().get();
Review comment:
would be simpler to use `CompletableFuture#join` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
