tillrohrmann commented on a change in pull request #9126:
[FLINK-13242][tests][coordination] Get SlotManager.failUnfulfillableRequest in
main thread of StandaloneResourceManager for verification
URL: https://github.com/apache/flink/pull/9126#discussion_r306354470
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManager.java
##########
@@ -92,6 +94,11 @@ protected void initialize() throws ResourceManagerException
{
}
}
+ @VisibleForTesting
+ CompletableFuture<Boolean> isFailingUnfulfillableRequestAsync() {
+ return
CompletableFuture.supplyAsync(this::isFailingUnfulfillableRequest,
getMainThreadExecutor());
+ }
Review comment:
I'd prefer to have these kind of methods in a
`TestingStandaloneResourceManager` because then they don't clutter the
production code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
