twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI] 
remember current catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#discussion_r305221777
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/DependencyTest.java
 ##########
 @@ -193,7 +200,20 @@ public Catalog createCatalog(String name, Map<String, 
String> properties) {
                                        ADDITIONAL_TEST_DATABASE,
                                        new CatalogDatabaseImpl(new 
HashMap<>(), null),
                                        false);
-                       } catch (DatabaseAlreadyExistException e) {
+                               hiveCatalog.createTable(
 
 Review comment:
   But you don't need a Hive catalog to test catalog functionality. You can 
simply create a test catalog similar to sources and sinks in this test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to