twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI] 
remember current catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#discussion_r304819837
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
 ##########
 @@ -232,7 +238,10 @@ public void useCatalog(SessionContext session, String 
catalogName) throws SqlExe
                        .getTableEnvironment();
 
 Review comment:
   @bowenli86 please remove `useCatalog` and `useDatabase` from the executor 
interface. The functionality is already covered by 
`org.apache.flink.table.client.gateway.local.LocalExecutor#validateSession`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to