pnowojski commented on a change in pull request #8811: [FLINK-12777][network]
Support CheckpointBarrierHandler in StreamTwoInputSelectableProcessor
URL: https://github.com/apache/flink/pull/8811#discussion_r297705063
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CachedBufferStorage.java
##########
@@ -43,14 +47,20 @@
/** The current memory queue for caching the buffers or events. */
private ArrayDeque<BufferOrEvent> currentBuffers;
+ @VisibleForTesting
+ CachedBufferStorage(int pageSize) {
Review comment:
Yes, you are kind of right. I introduced this to avoid code duplication. I
could have moved this constructor as a static helper method somewhere in the
tests, but I think there is no harm of making it public (and changing "Testing"
string to "Unknown").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
