c4emmmm commented on a change in pull request #8632: [FLINK-12744][ml] add
shared params in ml package
URL: https://github.com/apache/flink/pull/8632#discussion_r292362787
##########
File path: flink-ml-parent/pom.xml
##########
@@ -35,5 +35,6 @@ under the License.
<modules>
<module>flink-ml-api</module>
+ <module>flink-ml</module>
Review comment:
> There are two suggestions for the name of ml package
>
> * as the subdirectory of flink-ml-parent，flink-ml is simpler
> * the ml package with pipeline api in other tools is often named ml
>
> +1 for flink-ml
Why the parent module is named flink-ml-parent is to avoid the conflict with
flink-libraries/flink-ml in case of confusing users. For more details please
refer to the previous discussion in https://github.com/apache/flink/pull/8402 .
In this premise, no modules should be named flink-ml again. If not so,
flink-ml is better to use as the name of the parent module rather than that of
a sub module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
