azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce 
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289791224
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorSubmissionTest.java
 ##########
 @@ -774,6 +687,51 @@ public void testRequestStackTraceSample() throws 
Exception {
                }
        }
 
+       private TaskDeploymentDescriptor createSender(NettyShuffleDescriptor 
sdd) throws IOException {
+               return createSender(sdd, 
TestingAbstractInvokables.Sender.class);
+       }
+
+       private TaskDeploymentDescriptor createSender(
+                       NettyShuffleDescriptor shuffleDeploymentDescriptor,
+                       Class<? extends AbstractInvokable> abstractInvokable) 
throws IOException {
+               PartitionDescriptor partitionDescriptor = new 
PartitionDescriptor(
+                       new IntermediateDataSetID(),
+                       
shuffleDeploymentDescriptor.getResultPartitionID().getPartitionId(),
+                       ResultPartitionType.PIPELINED,
+                       1,
+                       0);
+               ResultPartitionDeploymentDescriptor 
resultPartitionDeploymentDescriptor = new ResultPartitionDeploymentDescriptor(
+                       partitionDescriptor,
+                       shuffleDeploymentDescriptor,
+                       1,
+                       true);
+               return createTestTaskDeploymentDescriptor(
+                       "Sender",
+                       
shuffleDeploymentDescriptor.getResultPartitionID().getProducerId(),
+                       abstractInvokable,
+                       1,
+                       
Collections.singletonList(resultPartitionDeploymentDescriptor),
+                       Collections.emptyList());
+       }
+
+       private TaskDeploymentDescriptor createReceiver(
+                       NettyShuffleDescriptor shuffleDescriptor,
+                       ResourceID location) throws IOException {
 
 Review comment:
   some tests rely on it to be the same as in some other components outside of 
this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to