azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce 
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289787297
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
 ##########
 @@ -212,7 +217,9 @@ public void testBackwardsEventWithUninitializedChannel() 
throws Exception {
                verify(taskEventDispatcher, 
times(1)).publish(any(ResultPartitionID.class), any(TaskEvent.class));
 
                // After the update, the pending event should be send to local 
channel
-               inputGate.updateInputChannel(new 
InputChannelDeploymentDescriptor(new 
ResultPartitionID(unknownPartitionId.getPartitionId(), 
unknownPartitionId.getProducerId()), ResultPartitionLocation.createLocal()));
+
+               ResourceID location = ResourceID.generate();
 
 Review comment:
   I think the random one provides a better check for tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to