azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289415869
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputGateDeploymentDescriptor.java
##########
@@ -54,24 +56,31 @@
* The index of the consumed subpartition of each consumed partition.
This index depends on the
* {@link DistributionPattern} and the subtask indices of the producing
and consuming task.
*/
+ @Nonnegative
private final int consumedSubpartitionIndex;
/** An input channel for each consumed subpartition. */
- private final InputChannelDeploymentDescriptor[] inputChannels;
+ private final ShuffleDescriptor[] inputChannels;
+
+ /**
+ * {@link ResourceID} of partition consume to identify its location.
+ *
+ * <p>It can be used e.g. to compare with partition producer {@link
ResourceID} in
+ * {@link ProducerDescriptor} to determine producer/consumer
co-location.
+ */
+ private final ResourceID consumerLocation;
Review comment:
actually I think it is better to rename it in `ProducerDescriptor &
NettyShuffleDescriptor `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
