azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r287368246
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorSubmissionTest.java
##########
@@ -504,26 +441,11 @@ public void testUpdateTaskInputPartitionsFailure()
throws Exception {
*/
@Test(timeout = 10000L)
public void testLocalPartitionNotFound() throws Exception {
- final ExecutionAttemptID eid = new ExecutionAttemptID();
-
- final IntermediateDataSetID resultId = new
IntermediateDataSetID();
- final ResultPartitionID partitionId = new ResultPartitionID();
-
- final ResultPartitionLocation loc =
ResultPartitionLocation.createLocal();
-
- final InputChannelDeploymentDescriptor[]
inputChannelDeploymentDescriptors =
- new InputChannelDeploymentDescriptor[] {
- new
InputChannelDeploymentDescriptor(partitionId, loc)};
-
- final InputGateDeploymentDescriptor
inputGateDeploymentDescriptor =
- new InputGateDeploymentDescriptor(resultId,
ResultPartitionType.PIPELINED, 0, inputChannelDeploymentDescriptors);
-
- final TaskDeploymentDescriptor tdd =
- createTestTaskDeploymentDescriptor("Receiver",
- eid,
- Tasks.AgnosticReceiver.class,
- 1, Collections.emptyList(),
-
Collections.singletonList(inputGateDeploymentDescriptor));
+ ResourceID producerLocation = new ResourceID("local");
+ DefaultShuffleDeploymentDescriptor sdd =
+ createSddWithLocalConnection(new
IntermediateResultPartitionID(), producerLocation, 10000);
+ TaskDeploymentDescriptor tdd = createReceiver(sdd,
producerLocation);
Review comment:
it should result in identifying that the partition is located locally in
SingleInputGateFactory on the consumer side, by comparing producer and consumer
resource ids.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
