azagrebin commented on a change in pull request #8529: [FLINK-12603][network]
Refactor InputGate interface to remove unnecessary methods
URL: https://github.com/apache/flink/pull/8529#discussion_r288489819
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -310,19 +310,20 @@ public Task(
Preconditions.checkArgument(0 <= attemptNumber, "The attempt
number must be positive.");
Preconditions.checkArgument(0 <= targetSlotNumber, "The target
slot number must be positive.");
- this.taskInfo = new TaskInfo(
- taskInformation.getTaskName(),
- taskInformation.getMaxNumberOfSubtaks(),
- subtaskIndex,
- taskInformation.getNumberOfSubtasks(),
- attemptNumber,
- String.valueOf(slotAllocationId));
+ this.taskInfo = TaskInfo.create(
+ taskInformation.getTaskName(),
+ taskInformation.getMaxNumberOfSubtaks(),
+ taskInformation.getNumberOfSubtasks(),
+ subtaskIndex,
+ attemptNumber,
+ String.valueOf(executionAttemptID),
Review comment:
nit: can `String.valueOf` happen inside `TaskInfo.create`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
