azagrebin commented on a change in pull request #8529: [FLINK-12603][network]
Refactor InputGate interface to remove unnecessary methods
URL: https://github.com/apache/flink/pull/8529#discussion_r288210167
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -53,9 +54,11 @@ public static CheckpointBarrierHandler
createCheckpointBarrierHandler(
}
if
(taskManagerConfig.getBoolean(NetworkEnvironmentOptions.NETWORK_CREDIT_MODEL)) {
- barrierHandler = new BarrierBuffer(inputGate,
new CachedBufferBlocker(inputGate.getPageSize()), maxAlign);
+ barrierHandler = new BarrierBuffer(
+ inputGate, new
CachedBufferBlocker(inputGate.getPageSize()), maxAlign, taskName);
} else {
- barrierHandler = new BarrierBuffer(inputGate,
new BufferSpiller(ioManager, inputGate.getPageSize()), maxAlign);
+ barrierHandler = new BarrierBuffer(
+ inputGate, new BufferSpiller(ioManager,
inputGate.getPageSize()), maxAlign, taskName);
Review comment:
codestyle: let's break all function argument into separate lines if the line
is broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
