zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r285027141
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java
##########
@@ -215,10 +215,9 @@ private void testReleaseMemory(final ResultPartitionType
resultPartitionType) th
final int numAllBuffers = 10;
final NetworkEnvironment network = new
NetworkEnvironmentBuilder()
.setNumNetworkBuffers(numAllBuffers).build();
- final ResultPartitionConsumableNotifier notifier = new
NoOpResultPartitionConsumableNotifier();
- final ResultPartition resultPartition =
createPartition(notifier, resultPartitionType, false);
+ final ResultPartition resultPartition =
createPartition(network, resultPartitionType, 1);
Review comment:
Actually the default value 1 is not needed, just because we could not give
all the possible units of parameters in `PartitionTestUtils`. So it might be
better to use `ResultPartitionBuilder` directly to delete intermediate
`PartitionTestUtils` as I mentioned above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
