zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r285004860
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -219,6 +211,17 @@ public SingleInputGate(
this.isCreditBased = isCreditBased;
}
+ @Override
+ public void setup() throws IOException {
Review comment:
In the setup, we should also `checkState(this.bufferPool == null)` firstly,
then it could void bring potential trouble of releasing the related buffers if
setup is called twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
