liyafan82 commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp… URL: https://github.com/apache/flink/pull/8397#issuecomment-492957173 > @liyafan82 The benchmarks results were exciting. > Can you use CodeGen's code to build some local benchmarks? You can put your code to your github branch. In this way, we can more easily reproduce. Hi @JingsongLi and @KurtYoung , thank you for the good suggestion. Evaluating local benchmarks can be time-consuming. To make the results reliable, a large amounts of data must be evaluated for many times times. In addition, a performance benchmark framework should be employed. If you really insist on this, I'd recommend JMH, which is the de factor standard. However, that may involve substantial changes, including opening a separate project, so I think we should do it in a separate JIRA. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
