[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

[GitBox]

sunjincheng121 commented on a change in pull request #8359: 
[FLINK-11051][table] Add streaming window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8359#discussion_r282791313
 
 

 ##########
 File path: 
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/plan/TableOperationConverter.java
 ##########
 @@ -174,7 +177,7 @@ public RelNode 
visitWindowAggregate(WindowAggregateTableOperation windowAggregat
                                .collect(toList());
                        GroupKey groupKey = relBuilder.groupKey(groupings);
                        LogicalWindow logicalWindow = 
toLogicalWindow(windowAggregate.getGroupWindow());
-                       return flinkRelBuilder.aggregate(logicalWindow, 
groupKey, windowProperties, aggregations).build();
+                       return flinkRelBuilder.aggregate(logicalWindow, 
groupKey, windowProperties, aggregations, isTableAggregate).build();
 
 Review comment:
   BTW: It's better to Unified naming aggregate and windowAggregate， in 
`AggregateOperationFactory` and `AggregateOperationFactory`. What do you think?
   ```
   AggregateOperationFactory#createAggregate
   AggregateOperationFactory#createWindowAggregate
   
   FlinkRelBuilder#aggregate(window: LogicalWindow)
   FlinkRelBuilder#aggregate(...)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services