bowenli86 commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r276851202
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.java ########## @@ -132,4 +133,31 @@ */ boolean tableExists(ObjectPath objectPath) throws CatalogException; + // ------ functions ------ + + /** + * Lists the names of all functions in the given database. An empty list is returned if none is registered. + * + * @param dbName Name of the database. + * @return A list of the names of all registered functions in this database. + * @throws DatabaseNotExistException + */ Review comment: the newly added ReadableCatalog APIs are missing javadoc for CatalogException ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services