bowenli86 commented on a change in pull request #8212: [FLINK-11519][table] Add 
function related catalog APIs
URL: https://github.com/apache/flink/pull/8212#discussion_r276850963
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogTest.java
 ##########
 @@ -646,4 +805,29 @@ private CatalogView createAnotherView() {
                        "This is another view");
        }
 
+       protected CatalogFunction createFunction() {
+               return new 
GenericCatalogFunction(MyOtherScalarFunction.class.getName());
 
 Review comment:
   should be `MyScalarFunction` rather than `MyOtherScalarFunction`. The below 
createAnotherFunction() uses `MyOtherScalarFunction` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to