tzulitai commented on a change in pull request #8122: [FLINK-12121] [State
Backends] Use composition instead of inheritance for the InternalKeyContext
logic in backend
URL: https://github.com/apache/flink/pull/8122#discussion_r273345835
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -218,10 +216,11 @@ public RocksDBKeyedStateBackend(
RocksDBNativeMetricMonitor nativeMetricMonitor,
RocksDBSerializedCompositeKeyBuilder<K> sharedRocksKeyBuilder,
PriorityQueueSetFactory priorityQueueFactory,
- RocksDbTtlCompactFiltersManager ttlCompactFiltersManager) {
+ RocksDbTtlCompactFiltersManager ttlCompactFiltersManager,
+ InternalKeyContext<K> keyContext) {
- super(kvStateRegistry, keySerializerProvider,
userCodeClassLoader, numberOfKeyGroups,
- keyGroupRange, executionConfig, ttlTimeProvider,
cancelStreamRegistry, keyGroupCompressionDecorator);
+ super(kvStateRegistry, keySerializerProvider,
userCodeClassLoader,
+ executionConfig, ttlTimeProvider, cancelStreamRegistry,
keyGroupCompressionDecorator, keyContext);
Review comment:
nit: separate lines for each argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
