tzulitai commented on a change in pull request #8122: [FLINK-12121] [State
Backends] Use composition instead of inheritance for the InternalKeyContext
logic in backend
URL: https://github.com/apache/flink/pull/8122#discussion_r273341969
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
##########
@@ -201,37 +199,34 @@ public boolean
deregisterKeySelectionListener(KeySelectionListener<K> listener)
*/
@Override
public TypeSerializer<K> getKeySerializer() {
- return keySerializerProvider.currentSchemaSerializer();
+ return keyContext.getCurrentKeySerializer();
}
/**
* @see KeyedStateBackend
*/
@Override
public K getCurrentKey() {
- return currentKey;
+ return this.keyContext.getCurrentKey();
}
/**
* @see KeyedStateBackend
*/
- @Override
public int getCurrentKeyGroupIndex() {
- return currentKeyGroup;
+ return this.keyContext.getCurrentKeyGroupIndex();
}
/**
* @see KeyedStateBackend
*/
- @Override
public int getNumberOfKeyGroups() {
return numberOfKeyGroups;
Review comment:
Why can't we also just depend on the `keyContext` for the number of key
groups and key group range also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
