dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r275349252
########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/operations/AggregateOperationFactory.java ########## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.operations; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.expressions.AggregateFunctionDefinition; +import org.apache.flink.table.expressions.ApiExpressionDefaultVisitor; +import org.apache.flink.table.expressions.BuiltInFunctionDefinitions; +import org.apache.flink.table.expressions.CallExpression; +import org.apache.flink.table.expressions.Expression; +import org.apache.flink.table.expressions.ExpressionBridge; +import org.apache.flink.table.expressions.FieldReferenceExpression; +import org.apache.flink.table.expressions.FunctionDefinition; +import org.apache.flink.table.expressions.LocalReferenceExpression; +import org.apache.flink.table.expressions.PlannerExpression; +import org.apache.flink.table.plan.logical.Aggregate; +import org.apache.flink.table.plan.logical.LogicalNode; +import org.apache.flink.table.plan.logical.LogicalWindow; +import org.apache.flink.table.plan.logical.SlidingGroupWindow; +import org.apache.flink.table.plan.logical.TumblingGroupWindow; +import org.apache.flink.table.plan.logical.WindowAggregate; +import org.apache.flink.table.typeutils.RowIntervalTypeInfo; + +import java.util.List; +import java.util.stream.Collectors; + +import static org.apache.flink.table.expressions.FunctionDefinition.Type.AGGREGATE_FUNCTION; + +/** + * Utility class for creating a valid {@link Aggregate} or {@link WindowAggregate}. + */ +@Internal +public class AggregateOperationFactory { + + private final boolean isStreaming; + private final ExpressionBridge<PlannerExpression> expressionBridge; + private final GroupingExpressionValidator groupingExpressionValidator = new GroupingExpressionValidator(); + private final NoChainedAggregates noChainedAggregates = new NoChainedAggregates(); + private final ValidateDistinct validateDistinct = new ValidateDistinct(); + + public AggregateOperationFactory(ExpressionBridge<PlannerExpression> expressionBridge, boolean isStreaming) { + this.expressionBridge = expressionBridge; + this.isStreaming = isStreaming; + } + + /** + * Creates a valid {@link Aggregate} operation. + * + * @param groupings expressions describing grouping key of aggregates + * @param aggregates expressions describing aggregation functions + * @param child relational operation on top of which to apply the aggregation + * @return valid aggregate operation + */ + public Aggregate createAggregate( + List<Expression> groupings, + List<Expression> aggregates, + TableOperation child) { + + LogicalNode childNode = (LogicalNode) child; + validateGroupings(groupings); + validateAggregates(groupings, aggregates); + + List<PlannerExpression> convertedGroupings = bridge(groupings); + List<PlannerExpression> convertedAggregates = bridge(aggregates); + return new Aggregate(convertedGroupings, convertedAggregates, childNode); + } + + /** + * Creates a valid {@link WindowAggregate} operation. + * + * @param groupings expressions describing grouping key of aggregates + * @param aggregates expressions describing aggregation functions + * @param windowProperties expressions describing window properties + * @param window grouping window of this aggregation + * @param child relational operation on top of which to apply the aggregation + * @return valid window aggregate operation + */ + public WindowAggregate createWindowAggregate( + List<Expression> groupings, + List<Expression> aggregates, + List<Expression> windowProperties, + LogicalWindow window, + TableOperation child) { + + LogicalNode childNode = (LogicalNode) child; + validateGroupings(groupings); + validateAggregates(groupings, aggregates); + + List<PlannerExpression> convertedGroupings = bridge(groupings); + List<PlannerExpression> convertedAggregates = bridge(aggregates); + List<PlannerExpression> convertedWindowProperties = bridge(windowProperties); + + validateWindow(windowProperties, window); + + return new WindowAggregate(convertedGroupings, window, convertedWindowProperties, convertedAggregates, childNode); + } + + private void validateWindow(List<Expression> windowProperties, LogicalWindow window) { + window.validate(isStreaming); + + if (!windowProperties.isEmpty()) { + if (window instanceof TumblingGroupWindow) { + PlannerExpression windowSize = ((TumblingGroupWindow) window).size(); + if (isRowCountLiteral(windowSize)) { + throw new ValidationException("Window start and Window end cannot be selected " + + "for a row-count Tumbling window."); + } + } else if (window instanceof SlidingGroupWindow) { + PlannerExpression windowSize = ((SlidingGroupWindow) window).size(); + if (isRowCountLiteral(windowSize)) { + throw new ValidationException("Window start and Window end cannot be selected " + + "for a row-count Sliding window."); + } + } + } + } + + private boolean isRowCountLiteral(PlannerExpression expr) { + return expr.resultType() == RowIntervalTypeInfo.INTERVAL_ROWS; + } + + private List<PlannerExpression> bridge(List<Expression> aggregates) { + return aggregates.stream() + .map(expressionBridge::bridge) + .collect(Collectors.toList()); + } + + private void validateGroupings(List<Expression> groupings) { + groupings.forEach(expr -> expr.accept(groupingExpressionValidator)); + } + + private void validateAggregates(List<Expression> groupings, List<Expression> aggregates) { + AggregationExpressionValidator aggregationsValidator = new AggregationExpressionValidator(groupings); + aggregates.forEach(agg -> agg.accept(aggregationsValidator)); + } + + private class AggregationExpressionValidator extends ApiExpressionDefaultVisitor<Void> { + + private final List<Expression> availableGroupings; + + private AggregationExpressionValidator(List<Expression> availableGroupings) { + this.availableGroupings = availableGroupings; + } + + @Override + public Void visitCall(CallExpression call) { + FunctionDefinition functionDefinition = call.getFunctionDefinition(); + if (functionDefinition.getType() == AGGREGATE_FUNCTION) { + if (functionDefinition == BuiltInFunctionDefinitions.DISTINCT) { + call.getChildren().forEach(expr -> expr.accept(validateDistinct)); + } else { + if (functionDefinition instanceof AggregateFunctionDefinition) { + if (requiresOver(functionDefinition)) { + throw new ValidationException(String.format( + "OVER clause is necessary for window functions: [%s].", + call)); + } + } + + call.getChildren().forEach(child -> child.accept(noChainedAggregates)); + } + } else { + call.getChildren().forEach(expr -> expr.accept(this)); + } + return null; + } + + private boolean requiresOver(FunctionDefinition functionDefinition) { + return ((AggregateFunctionDefinition) functionDefinition).getAggregateFunction().requiresOver(); + } + + @Override + public Void visitLocalReference(LocalReferenceExpression localReference) { + failExpression(localReference); + return null; + } + + @Override + public Void visitFieldReference(FieldReferenceExpression fieldReference) { + failExpression(fieldReference); + return null; + } + + @Override + protected Void defaultMethod(Expression expression) { + return null; + } + + private void failExpression(Expression expression) { + if (!availableGroupings.contains(expression)) { + throw new ValidationException(String.format("expression '%s' is invalid because it is neither" + + " present in group by nor an aggregate function", expression)); + } + } + } + + private class ValidateDistinct extends ApiExpressionDefaultVisitor<Void> { + + @Override + public Void visitCall(CallExpression call) { + if (call.getFunctionDefinition() == BuiltInFunctionDefinitions.DISTINCT) { + throw new ValidationException("It's not allowed to use an aggregate function as " + + "input of another aggregate function"); + } else if (call.getFunctionDefinition().getType() != AGGREGATE_FUNCTION) { + throw new ValidationException("Distinct operator can only be applied to aggregation expressions!"); + } else { + call.getChildren().forEach(child -> child.accept(noChainedAggregates)); + } + return null; + } + + @Override + protected Void defaultMethod(Expression expression) { + return null; + } + } + + private class NoChainedAggregates extends ApiExpressionDefaultVisitor<Void> { + + @Override + public Void visitCall(CallExpression call) { + if (call.getFunctionDefinition().getType() == AGGREGATE_FUNCTION) { + throw new ValidationException("It's not allowed to use an aggregate function as " + + "input of another aggregate function"); + } + return null; Review comment: Good catch, I misinterpreted `preOrderVisit` method in the old code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
