azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r271453248
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java ########## @@ -56,64 +61,25 @@ private final TaskEventDispatcher taskEventDispatcher; - private final int partitionRequestInitialBackoff; - - private final int partitionRequestMaxBackoff; - - /** Number of network buffers to use for each outgoing/incoming channel (subpartition/input channel). */ Review comment: let's keep these 2 doc comments for `networkBuffersPerChannel` and `extraNetworkBuffersPerGate` in `NetworkEnvironmentConfiguration`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services