azagrebin commented on a change in pull request #8090: [FLINK-12067][network]
Refactor the constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090#discussion_r271827710
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
##########
@@ -132,27 +118,27 @@ public TaskManagerServicesConfiguration(
// Getter/Setter
//
--------------------------------------------------------------------------------------------
- public InetAddress getTaskManagerAddress() {
+ InetAddress getTaskManagerAddress() {
return taskManagerAddress;
}
public String[] getTmpDirPaths() {
return tmpDirPaths;
}
- public String[] getLocalRecoveryStateRootDirectories() {
+ String[] getLocalRecoveryStateRootDirectories() {
return localRecoveryStateRootDirectories;
}
- public boolean isLocalRecoveryEnabled() {
+ boolean isLocalRecoveryEnabled() {
return localRecoveryEnabled;
}
public NetworkEnvironmentConfiguration getNetworkConfig() {
return networkConfig;
}
- public QueryableStateConfiguration getQueryableStateConfig() {
+ QueryableStateConfiguration getQueryableStateConfig() {
Review comment:
let's also annotate with `@Nullable` as private field `queryableStateConfig`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
