TisonKun commented on a change in pull request #7927: [FLINK-11603][metrics]
Port the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r268377110
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceUtils.java
##########
@@ -100,11 +100,11 @@ public static RpcService createRpcService(
int port,
Configuration configuration) throws Exception {
final ActorSystem actorSystem =
BootstrapTools.startActorSystem(configuration, hostname, port, LOG);
- return instantiateAkkaRpcService(configuration, actorSystem);
+ return createRpcService(configuration, actorSystem);
}
@Nonnull
- private static RpcService instantiateAkkaRpcService(Configuration
configuration, ActorSystem actorSystem) {
+ public static RpcService createRpcService(Configuration configuration,
ActorSystem actorSystem) {
Review comment:
Introduce a method `#createRpcService(String, String, Configuration, String,
BootstrapTools.ActorSystemExecutorConfiguration)` instead of make
`#instantiateAkkaRpcService(Configuration, ActorSystem) ` public
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
