TisonKun commented on a change in pull request #7927: [FLINK-11603][metrics]
Port the MetricQueryService to the new RpcEndpoint
URL: https://github.com/apache/flink/pull/7927#discussion_r268373838
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/TestingRestfulGateway.java
##########
@@ -269,13 +270,13 @@ public Builder
setRequestClusterOverviewSupplier(Supplier<CompletableFuture<Clus
return this;
}
- public Builder
setRequestMetricQueryServicePathsSupplier(Supplier<CompletableFuture<Collection<String>>>
requestMetricQueryServicePathsSupplier) {
- this.requestMetricQueryServicePathsSupplier =
requestMetricQueryServicePathsSupplier;
+ public Builder
setRequestMetricQueryServiceGatewaysSupplier(Supplier<CompletableFuture<Collection<MetricQueryServiceGateway>>>
requestMetricQueryServiceGatewaysSupplier) {
+ this.requestMetricQueryServiceGatewaysSupplier =
requestMetricQueryServiceGatewaysSupplier;
return this;
}
- public Builder
setRequestTaskManagerMetricQueryServicePathsSupplier(Supplier<CompletableFuture<Collection<Tuple2<ResourceID,
String>>>> requestTaskManagerMetricQueryServicePathsSupplier) {
- this.requestTaskManagerMetricQueryServicePathsSupplier
= requestTaskManagerMetricQueryServicePathsSupplier;
+ public Builder
setRequestTaskManagerMetricQueryServiceGatewaysSupplier(Supplier<CompletableFuture<Collection<Tuple2<ResourceID,
MetricQueryServiceGateway>>>>
requestTaskManagerMetricQueryServiceGatewaysSupplier) {
Review comment:
Given the return value is `Collection<Tuple2<ResourceID,
MetricQueryServiceGateway>>` and means return the gateways of TaskManagers'
MQS, I'd like to keep "s". However, we have outdate document of
`requestTaskManagerMetricQueryServiceGateways` that should be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
