[ https://issues.apache.org/jira/browse/FLINK-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790378#comment-16790378 ]
Hequn Cheng commented on FLINK-11068: ------------------------------------- [~dawidwys] Thanks for your valuable suggestions. I think you make a good point here, it's better to assure compatibility for our APIs. And we can discuss it later, if we feel need to. As for the time of opening the PR, I planned to do it right after the Expression PR merged(FLINK-11449). Because the table interface can only be put into api-java when Expression has been moved into flink-common. I think we have two options now: * Wait until FLINK-11449 is merged. Maybe very soon or a few days? * Put table interface in planner module temporary and move it into api-java later. This can avoid the "block chain" and speed up our work if FLINK-11449 still needs some time. What do you think? [~twalthr] [~dawidwys] > Convert the API classes *Table, *Window to interfaces > ----------------------------------------------------- > > Key: FLINK-11068 > URL: https://issues.apache.org/jira/browse/FLINK-11068 > Project: Flink > Issue Type: Improvement > Components: API / Table SQL > Reporter: Timo Walther > Assignee: Hequn Cheng > Priority: Major > > A more detailed description can be found in > [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions]. > This includes: Table, GroupedTable, WindowedTable, WindowGroupedTable, > OverWindowedTable, Window, OverWindow > We can keep the "Table" Scala implementation in a planner module until it has > been converted to Java. > We can add a method to the planner later to give us a concrete instance. This > is one possibility to have a smooth transition period instead of changing all > classes at once. -- This message was sent by Atlassian JIRA (v7.6.3#76005)