[ 
https://issues.apache.org/jira/browse/FLINK-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790352#comment-16790352
 ] 

Dawid Wysakowicz commented on FLINK-11068:
------------------------------------------

Hi [~hequn8128] thanks for working on this issue.
Ad.1 Yes
Ad.2 I don't think this is feasible right now. This would be a breaking API 
change. We would need to deprecate the Window first. I don't see as much 
benefit so that it would make sense to do it now.
Ad.3 Yes, we should not touch those for now. They might end up in the 
{{flink-table-api-scala-bridge}} at some point.

By the way do you know when can you open PR for the interface extraction? I 
already started migrating the Table to java, so I think it would make sense to 
base it on top of your changes.

> Convert the API classes *Table, *Window to interfaces
> -----------------------------------------------------
>
>                 Key: FLINK-11068
>                 URL: https://issues.apache.org/jira/browse/FLINK-11068
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Table SQL
>            Reporter: Timo Walther
>            Assignee: Hequn Cheng
>            Priority: Major
>
> A more detailed description can be found in 
> [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions].
> This includes: Table, GroupedTable, WindowedTable, WindowGroupedTable, 
> OverWindowedTable, Window, OverWindow
> We can keep the "Table" Scala implementation in a planner module until it has 
> been converted to Java.
> We can add a method to the planner later to give us a concrete instance. This 
> is one possibility to have a smooth transition period instead of changing all 
> classes at once.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to