[ 
https://issues.apache.org/jira/browse/FLINK-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777913#comment-16777913
 ] 

Timo Walther commented on FLINK-11067:
--------------------------------------

Thanks for the summary [~hequn8128].

*Dependencies*
Your dependency observations make sense to me. They are known and also covered 
in the "API Preparation" part of FLIP-32.

*TableConfig*
For this issue, I opened FLINK-11728 last week. I think it is ok to also remove 
this method temporarily. We can later think of a new possibility to extend the 
planner. {{CalciteConfig}} has also optimizer phases that only apply to Flink's 
optimizer not the new Blink one. What do you think of a new {{PlannerConfig}} 
base class in {{flink-table-java-api}} and planner specific 
{{DefaultPlannerConfig extends PlannerConfig}} in {{flink-table-planner-blink}} 
and {{flink-table-planner}}? {{setPlannerConfig()}} could replace the old 
{{setCalcliteConfig}}.

*TableEnvironment interface*
Sounds good to me :-)



> Convert TableEnvironments to interfaces
> ---------------------------------------
>
>                 Key: FLINK-11067
>                 URL: https://issues.apache.org/jira/browse/FLINK-11067
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Hequn Cheng
>            Priority: Major
>
> A more detailed description can be found in 
> [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions].
> This task includes porting {{TableEnvironment}}, {{StreamTableEnvironment}}, 
> {{BatchTableEnvironment}} to Java interfaces. API-breaking changes should not 
> be necessary anymore as they should have been resolved by sibling issues. 
> Some refactoring and clean up might be necessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to