dawidwys commented on a change in pull request #7747: [FLINK-11653][DataStream] 
Add configuration to enforce custom UID's o…
URL: https://github.com/apache/flink/pull/7747#discussion_r259373777
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
 ##########
 @@ -348,6 +348,13 @@ private StreamConfig createJobVertex(
                                        "Did you generate them before calling 
this method?");
                }
 
+               if 
(!streamGraph.getExecutionConfig().hasAutoGeneratedUIDsEnabled()) {
 
 Review comment:
   I am pretty sure you can, and all operators are used to generate OperatorId. 
See 
`org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator#createJobVertex:368-394`.
 
   
   Also see the ctor of `JobVertex`, it's true that the id of head operator is 
used as `primaryId`, but all chained operator ids are passed as `operatorIds`, 
which is later used in e.g. 
`org.apache.flink.runtime.checkpoint.StateAssignmentOperation#assignTaskStateToExecutionJobVertices`
 to assign proper state(s).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to