dawidwys commented on a change in pull request #7747: [FLINK-11653][DataStream] 
Add configuration to enforce custom UID's o…
URL: https://github.com/apache/flink/pull/7747#discussion_r259360952
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
 ##########
 @@ -348,6 +348,13 @@ private StreamConfig createJobVertex(
                                        "Did you generate them before calling 
this method?");
                }
 
+               if 
(!streamGraph.getExecutionConfig().hasAutoGeneratedUIDsEnabled()) {
 
 Review comment:
   I tend to disagree. AFAIK for state mapping purposes all OperatorIds are 
preserved, even those that are chained into a single operator chain (a single 
chained JobVertex), otherwise it would be impossible to e.g. restore job with 
changed chaining, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to