carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257723581
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java ########## @@ -181,7 +182,42 @@ keyGroupRange, kvStateRegistry, ttlTimeProvider, - new UnregisteredMetricsGroup()); + new UnregisteredMetricsGroup(), + null); Review comment: Will use empty collection and add `@Nonnull` annotation, but since it's not an assertion I guess we still need null checkers before using `stateHandles`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services