carp84 commented on a change in pull request #7674: [FLINK-10043] [State
Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r256675319
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
##########
@@ -458,7 +460,8 @@ public CheckpointStorage createCheckpointStorage(JobID
jobId) throws IOException
KeyGroupRange keyGroupRange,
TaskKvStateRegistry kvStateRegistry,
TtlTimeProvider ttlTimeProvider,
- MetricGroup metricGroup) {
+ MetricGroup metricGroup,
+ Collection<KeyedStateHandle> stateHandles) {
Review comment:
I agree that all backend should follow the builder way in the end, and
that's why AbstractKeyedStateBackendBuilder is introduced in the commit here.
Maybe we could focus on rocksdb here then the others in a separate JIRA/PR?
Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
