GJL commented on a change in pull request #7676: [FLINK-11364][tests] Port
TaskManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/7676#discussion_r256295246
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/TestingMiniCluster.java
##########
@@ -74,8 +74,13 @@ public TestingMiniCluster(TestingMiniClusterConfiguration
miniClusterConfigurati
}
@Override
- public void startTaskExecutor(boolean localCommunication) throws
Exception {
Review comment:
Is it crucial for testing to be able to set the right `localCommunication`
flag? If yes, a method overload that sets `localCommunication` to `false` would
have been enough but I am not insisting on it.
_edit:_ alternatively always use `false` with no option to override (if
possible)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
