GJL commented on a change in pull request #7676: [FLINK-11364][tests] Port
TaskManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/7676#discussion_r256296275
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -696,34 +686,38 @@ protected ResourceManagerRunner startResourceManager(
return resourceManagerRunner;
}
- protected TaskExecutor[] startTaskManagers(
- Configuration configuration,
- HighAvailabilityServices haServices,
- HeartbeatServices heartbeatServices,
- MetricRegistry metricRegistry,
- BlobCacheService blobCacheService,
- int numTaskManagers,
- RpcServiceFactory rpcServiceFactory) throws Exception {
+ @GuardedBy("lock")
+ private void startTaskManagers() throws Exception {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
