tzulitai commented on a change in pull request #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#discussion_r255405420
########## File path: flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/TraversableSerializerSnapshot.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.scala.typeutils; + +import org.apache.flink.api.common.typeutils.CompositeTypeSerializerSnapshot; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; + +import java.io.IOException; + +import scala.collection.TraversableOnce; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkState; + +/** + * A {@link org.apache.flink.api.common.typeutils.TypeSerializerSnapshot} for the Scala + * {@link TraversableSerializer}. + * + * <p>This configuration snapshot class is implemented in Java because Scala does not + * allow calling different base class constructors from subclasses, while we need that + * for the default empty constructor. + */ +public class TraversableSerializerSnapshot<T extends TraversableOnce<E>, E> + extends CompositeTypeSerializerSnapshot<T, TraversableSerializer<T, E>> { + + private static final int VERSION = 1; Review comment: Lets start from 2, just to remain consistent with the other serializer changes and reserver 1 just in case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
