twalthr commented on a change in pull request #7664: [FLINK-11449][table]
Uncouple the Expression class from RexNodes.
URL: https://github.com/apache/flink/pull/7664#discussion_r255066406
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
##########
@@ -414,15 +414,15 @@ abstract class BatchTableEnvironment(
* @tparam T The type of the [[DataSet]].
*/
protected def registerDataSetInternal[T](
- name: String, dataSet: DataSet[T], fields: Array[Expression]): Unit = {
+ name: String, dataSet: DataSet[T], fields: Array[PlannerExpression]):
Unit = {
val inputType = dataSet.getType
val (fieldNames, fieldIndexes) = getFieldInfo[T](
inputType,
fields)
- if (fields.exists(_.isInstanceOf[TimeAttribute])) {
+ if (fields.exists(_.isInstanceOf[PlannerTimeAttribute])) {
Review comment:
Do we really want to rename all expression now? I would have kept the amount
of changes to a minimum, also to not break to much implementations. I'm sure
that a lot of people also use the expression case classes directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
