[
https://issues.apache.org/jira/browse/FLINK-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699589#comment-16699589
]
ASF GitHub Bot commented on FLINK-10997:
----------------------------------------
dawidwys commented on issue #7170: [FLINK-10997][formats] Bundle
kafka-scheme-registry-client
URL: https://github.com/apache/flink/pull/7170#issuecomment-441799465
How about if we include just what we need for the confluent schema-registry
in the uber-jar:
<configuration>
<artifactSet>
<includes>
<include>io.confluent:*</include>
<include>com.fasterxml.jackson.core:*</include>
<include>org.apache.zookeeper:zookeeper</include>
<include>com.101tec:zkclient</include>
</includes>
</artifactSet>
<relocations combine.children="append">
<relocation>
<pattern>com.fasterxml.jackson</pattern>
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.com.fasterxml.jackson</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.zookeeper</pattern>
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.org.apache.zookeeper</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.jute</pattern>
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.org.apache.jute</shadedPattern>
</relocation>
<relocation>
<pattern>org.I0Itec.zkclient</pattern>
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.org.101tec</shadedPattern>
</relocation>
</relocations>
</configuration>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Avro-confluent-registry does not bundle any dependency
> ------------------------------------------------------
>
> Key: FLINK-10997
> URL: https://issues.apache.org/jira/browse/FLINK-10997
> Project: Flink
> Issue Type: Bug
> Components: Formats, Table API & SQL
> Affects Versions: 1.6.2, 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> The {{flink-avro-confluent-registry}} is not bundling any dependencies, yet
> defines a relocation for the transitive jackson dependency pulled in by
> {{kafka-schema-registry-client}}.
> It is like that the registry-client should be included in the jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
