[
https://issues.apache.org/jira/browse/FLINK-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711269#comment-16711269
]
ASF GitHub Bot commented on FLINK-10997:
----------------------------------------
zentol closed pull request #7170: [FLINK-10997][formats] Bundle
kafka-scheme-registry-client
URL: https://github.com/apache/flink/pull/7170
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-formats/flink-avro-confluent-registry/pom.xml
b/flink-formats/flink-avro-confluent-registry/pom.xml
index 72a74ac11ba..4c99f71e544 100644
--- a/flink-formats/flink-avro-confluent-registry/pom.xml
+++ b/flink-formats/flink-avro-confluent-registry/pom.xml
@@ -78,10 +78,31 @@ under the License.
<goal>shade</goal>
</goals>
<configuration>
+
<shadeTestJar>false</shadeTestJar>
+ <artifactSet>
+ <includes>
+
<include>io.confluent:*</include>
+
<include>com.fasterxml.jackson.core:*</include>
+
<include>org.apache.zookeeper:zookeeper</include>
+
<include>com.101tec:zkclient</include>
+ </includes>
+ </artifactSet>
<relocations
combine.children="append">
<relocation>
-
<pattern>com.fasterxml.jackson.core</pattern>
-
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.com.fasterxml.jackson.core</shadedPattern>
+
<pattern>com.fasterxml.jackson</pattern>
+
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.com.fasterxml.jackson</shadedPattern>
+ </relocation>
+ <relocation>
+
<pattern>org.apache.zookeeper</pattern>
+
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.org.apache.zookeeper</shadedPattern>
+ </relocation>
+ <relocation>
+
<pattern>org.apache.jute</pattern>
+
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.org.apache.jute</shadedPattern>
+ </relocation>
+ <relocation>
+
<pattern>org.I0Itec.zkclient</pattern>
+
<shadedPattern>org.apache.flink.formats.avro.registry.confluent.shaded.org.101tec</shadedPattern>
</relocation>
</relocations>
</configuration>
diff --git
a/flink-formats/flink-avro-confluent-registry/src/main/resources/META-INF/NOTICE
b/flink-formats/flink-avro-confluent-registry/src/main/resources/META-INF/NOTICE
new file mode 100644
index 00000000000..24f2ff84657
--- /dev/null
+++
b/flink-formats/flink-avro-confluent-registry/src/main/resources/META-INF/NOTICE
@@ -0,0 +1,15 @@
+flink-avro-confluent-registry
+Copyright 2014-2018 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software
License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- com.101tec:zkclient:0.10
+- com.fasterxml.jackson.core:jackson-databind:2.8.4
+- com.fasterxml.jackson.core:jackson-annotations:2.8.0
+- com.fasterxml.jackson.core:jackson-core:2.8.4
+- io.confluent:common-utils:3.3.1
+- io.confluent:kafka-schema-registry-client:3.3.1
+- org.apache.zookeeper:zookeeper:3.4.10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Avro-confluent-registry does not bundle any dependency
> ------------------------------------------------------
>
> Key: FLINK-10997
> URL: https://issues.apache.org/jira/browse/FLINK-10997
> Project: Flink
> Issue Type: Bug
> Components: Formats, Table API & SQL
> Affects Versions: 1.6.2, 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> The {{flink-avro-confluent-registry}} is not bundling any dependencies, yet
> defines a relocation for the transitive jackson dependency pulled in by
> {{kafka-schema-registry-client}}.
> It is like that the registry-client should be included in the jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
