zhijiangW commented on a change in pull request #7051: [FLINK-10820][network]
Simplify the RebalancePartitioner implementation
URL: https://github.com/apache/flink/pull/7051#discussion_r236288001
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
##########
@@ -412,23 +412,24 @@ public void testBroadcastEmitRecord() throws Exception {
*
* @param isBroadcastEmit whether using {@link
RecordWriter#broadcastEmit(IOReadableWritable)} or not
*/
+ @SuppressWarnings("unchecked")
private void
emitRecordWithBroadcastPartitionerOrBroadcastEmitRecord(boolean
isBroadcastEmit) throws Exception {
final int numChannels = 4;
final int bufferSize = 32;
final int numValues = 8;
final int serializationLength = 4;
- @SuppressWarnings("unchecked")
Review comment:
There are two places for this issue in this method, another one is
`final RecordWriter<SerializationTestType> writer = isBroadcastEmit ?
new RecordWriter<>(partitionWriter) : new
RecordWriter<>(partitionWriter, selector);`
So I put this suppression on top of the method to apply for both.
It is not necessary to have this suppression I think. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
