zhijiangW commented on a change in pull request #7051: [FLINK-10820][network] 
Simplify the RebalancePartitioner implementation
URL: https://github.com/apache/flink/pull/7051#discussion_r236287926
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RoundRobinChannelSelector.java
 ##########
 @@ -32,9 +32,16 @@
        /** Stores the index of the channel to send the next record to. */
        private final int[] nextChannelToSendTo = new int[] { -1 };
 
+       private int numChannels;
 
 Review comment:
   I will take `numberOfChannels` instead. 
   BTW, i think we should unify this variable naming in other places like 
`StreamPartitioner`, etc. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to