[
https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696540#comment-16696540
]
ASF GitHub Bot commented on FLINK-8577:
---------------------------------------
pnowojski commented on issue #6787: [FLINK-8577][table] Implement proctime
DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#issuecomment-441185723
I've started reviewing the code and as we talked offline, could you split
this PR into 4 commits:
- Add `fromAppendStream` and Deprecate `fromDataStream`
- Introduce `LastRow` Rules
- Introduce `LastRow` runtime functions
- Optimize upsert sources followed by `Calc`
? Having more, smaller, independent commits speeds up reviewing and help in
the future whenever someone is digging through git's commit history to
understand why/how was something implemented. Especially splitting of
refactoring/renaming commits from feature adding/changing or bug fixing commits
is important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement proctime DataStream to Table upsert conversion.
> ---------------------------------------------------------
>
> Key: FLINK-8577
> URL: https://issues.apache.org/jira/browse/FLINK-8577
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
> Labels: pull-request-available
>
> Api will looks like:
> {code:java}
> DataStream[(String, Long, Int)] input = ???
> // upsert with keyTable
> table = tEnv.upsertFromStream(input, 'a, 'b, 'c.key)
> // upsert without key -> single row tableTable
> table = tEnv.upsertFromStream(input, 'a, 'b, 'c){code}
> A simple design
> [doc|https://docs.google.com/document/d/1yMEi9xkm3pNYNmmZykbLzqtKjFVezaWe0y7Xqd0c1zE/edit?usp=sharing]
> about this subtask.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
