[
https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696467#comment-16696467
]
ASF GitHub Bot commented on FLINK-8577:
---------------------------------------
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r235835262
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
##########
@@ -165,7 +165,30 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder)
extends RelShuttle {
override def visit(exchange: LogicalExchange): RelNode =
throw new TableException("Logical exchange in a stream environment is not
supported yet.")
- override def visit(scan: TableScan): RelNode = scan
+ override def visit(scan: TableScan): RelNode = {
+ val upsertStreamTable = scan.getTable.unwrap(classOf[UpsertStreamTable[_]])
+ val relTypes = scan.getRowType.getFieldList.map(_.getType)
+ val getTimeIndicatorIndexes = relTypes.zipWithIndex
+ .filter(e => FlinkTypeFactory.isTimeIndicatorType(e._1))
+ .map(_._2)
+ if (upsertStreamTable != null) {
+ val input = if (getTimeIndicatorIndexes.size > 0) {
+ // materialize time indicator
+ val rewrittenScan = scan.copy(scan.getTraitSet, scan.getInputs)
+ materializerUtils.projectAndMaterializeFields(rewrittenScan,
getTimeIndicatorIndexes.toSet)
+ } else {
+ scan
+ }
+
+ LogicalLastRow.create(
Review comment:
Year, It would be nice if we can. However, it is not easy to generate
LastRow in a Rule. For example, with the following rule:
```
class GenerateLastRowRule extends RelOptRule(
operand(classOf[TableScan], none),
"GenerateLastRowRule") {
...
}
```
The Rule will apply infinitly. Moreover, we can't write the rule with two
operands, because some plan may only contain one Scan node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement proctime DataStream to Table upsert conversion.
> ---------------------------------------------------------
>
> Key: FLINK-8577
> URL: https://issues.apache.org/jira/browse/FLINK-8577
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
> Labels: pull-request-available
>
> Api will looks like:
> {code:java}
> DataStream[(String, Long, Int)] input = ???
> // upsert with keyTable
> table = tEnv.upsertFromStream(input, 'a, 'b, 'c.key)
> // upsert without key -> single row tableTable
> table = tEnv.upsertFromStream(input, 'a, 'b, 'c){code}
> A simple design
> [doc|https://docs.google.com/document/d/1yMEi9xkm3pNYNmmZykbLzqtKjFVezaWe0y7Xqd0c1zE/edit?usp=sharing]
> about this subtask.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
